Replace websocket dependency with ws
#2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Since this PR makes a small tweak to |
twiggy diff reportDifference in .wasm size before and after this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2588
The
websocketpackage on NPM is just kind of fucked up, and it is impossible to make it work on both ModuleJS and CommonJS. This PR switches tows, which works fine.This was previously not possible because we were using the
websocketlibrary in the browser as well. This is no longer the case.The biggest effort was updating the demo.
Additionally, I've made some tweaks to the
tsconfig.jsonto disable some magic features. I removed them as a first attempt at understanding the issue. They turned out to be unrelated, but they're better left disabled anyway.